Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to use custom workspace #30

Closed
wants to merge 4 commits into from

Conversation

tatsta
Copy link

@tatsta tatsta commented Mar 10, 2020

Description of the Change

Add a possibility to specify workspace folder as environment variable WORKSPACE_DIR in case the Wordpress artefact files are located in custom folder. If environment variable WORKSPACE_DIR is not set GITHUB_WORKSPACE variable (and path) will be used

Alternate Designs

Tried to redefine GITHUB_WORKSPACE variable when passing it into the action, but that didn't work for me.

Benefits

The actions is more reusable in other use cases

Possible Drawbacks

Verification Process

I tested on a fork with .distignore and .gitattributes, both seemed to work fine.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

@helen
Copy link
Collaborator

helen commented Mar 10, 2020

Hi @tatsta - thanks for sending this in. Is this to address #16?

@tatsta
Copy link
Author

tatsta commented Mar 11, 2020

Hi! Yes, hopefully this could solve it

@Lewiscowles1986
Copy link

I have re-based this and slightly altered what was here @tatsta & @helen I'd appreciate 👀 or responses if you find time.

For me not having this is preventing me from having a release github action. I Could totally roll my own, but if #16 and this are anything to go by, the issue affects a lot of people.

Differences:

  • I decided .gitattributes and other ignore files SHOULD continue to live in the root of the repository. For me this is not about obfuscation, but rather shipping only what is needed for Runtime in WP and the plugin directory.
  • I decided the assets folder should also be relative to the root of the repository. This does not prevent people moving it, but it means they don't mentally need to resolve paths I hope.

Thanks to both.

@jeffpaul jeffpaul added this to the 1.6.0 milestone Mar 22, 2021
@jeffpaul jeffpaul linked an issue Jan 5, 2022 that may be closed by this pull request
@jeffpaul jeffpaul modified the milestones: 2.1.0, 2.2.0 May 11, 2022
@dkotter dkotter removed the request for review from dinhtungdu August 23, 2022 22:13
@jeffpaul
Copy link
Member

@iamdharmesh bumping back up for your review.

@iamdharmesh
Copy link
Member

@jeffpaul This is already handled by Tung's PR #83. So, we can proceed with closing this. Please feel free to reopen if I missed anything or misunderstood anything here.

Thanks

@iamdharmesh iamdharmesh closed this Jan 6, 2023
@jeffpaul jeffpaul removed this from the 2.2.0 milestone Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy a specific directory within repository
5 participants