Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate away from defaultProps #314

Closed
fabiankaegy opened this issue Apr 30, 2024 · 1 comment · Fixed by #331
Closed

Migrate away from defaultProps #314

fabiankaegy opened this issue Apr 30, 2024 · 1 comment · Fixed by #331
Labels
Good First Issue Good for newcomers Needs Help Extra attention is needed [Type] Code Quality

Comments

@fabiankaegy
Copy link
Member

prop types / defaultProps were deprecated all the way in 2017 and are now getting removed in React 19.

WordPress will likely update it's React version relatively soon after the release so we should ensure we are finally finishing the migration away from defaultProps

https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-deprecated-react-apis
@fabiankaegy fabiankaegy added Good First Issue Good for newcomers Needs Help Extra attention is needed [Type] Code Quality labels Apr 30, 2024
Antonio-Laguna added a commit that referenced this issue May 13, 2024
@Antonio-Laguna
Converting IconPicker to TypeScript
7e193ba 
#314 #295
@Antonio-Laguna Antonio-Laguna mentioned this issue May 13, 2024
Merged
4 tasks
This was referenced May 13, 2024
Merged
Merged
@001123
Copy link

001123 commented May 24, 2024

is any tool for migrate defaultProps ?

@fabiankaegy fabiankaegy mentioned this issue Jun 11, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Good for newcomers Needs Help Extra attention is needed [Type] Code Quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove: defaultProps & propTypes definitions from remaining components 10up/block-components
2 participants
@fabiankaegy @001123