Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment of Popover in Link Component #157

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

fabiankaegy
Copy link
Member

@fabiankaegy fabiankaegy commented Oct 13, 2022

Description of the Change

Starting in WordPress 6.1 the behavior of the Popover changes slightly and manually positioned popovers don't auto change their position. Therefore we are removing the manual placement in favor of full auto-placement to prevent overflow issues.

Before:

CleanShot.2022-10-13.at.12.50.38.mp4

After:

CleanShot.2022-10-13.at.12.51.03.mp4

How to test the Change

Changelog Entry

Fixed - Positioning of Popover in Link Component

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@fabiankaegy fabiankaegy added [Type] Bug Something isn't working [Component] Link labels Oct 13, 2022
@fabiankaegy fabiankaegy self-assigned this Oct 13, 2022
@fabiankaegy fabiankaegy merged commit b519543 into develop Oct 13, 2022
@fabiankaegy fabiankaegy deleted the fix/link-popover-alignement branch October 13, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Link [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant