Conditional Display of Helper Text for AI Provider Account Creation #770
Conversation
kmgalanakis
force-pushed
the
feature/hide-help-text-if-feature-enabled
branch
from
b7d5c2b
to
6940eae
Compare
| 'title' => [], | ||
| ], | ||
| ] | ||
| 'description' => $this->feature_instance->is_feature_enabled() ? |
There was a problem hiding this comment.
So the is_feature_enabled method checks three things:
- Is the Provider configured properly?
- Does the current user have access to this Feature?
- Is the Feature turned on?
This is probably fine when someone is setting things up through the onboarding wizard but if changing things from the settings page, this means the helper text won't show if the Feature isn't turned on. This leads to the scenario where the only way to see the helper text is turning the Feature on and then saving the settings.
I think it may be better to use the is_configured method, so we aren't running a user check or enabled check but just checking if the Provider is configured.
There was a problem hiding this comment.
Hello @dkotter.
Good point. However, instead of just checking if the feature is configured I preferred to check if the feature is configured with the specified provider. The problem was that when using just is_configured the feature might have been configured with provider A and that would result in hiding the help texts of provider B for the same service. With my approach, the help texts of a provider are only hidden if the feature is configured with the specified provider.
Please let me know what you think.
Thank you
| 'class' => 'classifai-provider-field hidden provider-scope-' . static::ID, // Important to add this. | ||
| ] | ||
| ); | ||
| if ( ! $this->feature_instance->is_feature_enabled() ) { |
There was a problem hiding this comment.
I don't think we want to hide this toggle as someone may want to switch from using an API key to using a Username and Password, which this makes that impossible unless they remove credentials first or disable the Feature first.
There was a problem hiding this comment.
Good point @dkotter, thank you. This should be fine now.
…ured" and always show the option to switch to authenticating with username and password
…ers when the feature is configured with the selected provider
github-actions
bot
added
the
needs:feedback
|
@kmgalanakis thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this? |
kmgalanakis
changed the title
Description of the Change
Closes #715
How to test the Change
Changelog Entry
Credits
Props @kmgalanakis
Checklist: