Internal distribution should prepare posts the same for push or pull #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will fix whatever is causing the build to fail and push it again. |
rmarscher
force-pushed
the
internal-push-meta-terms-filter
branch
2 times, most recently
from
e40a3fa
to
ad7f3c1
Compare
rmarscher
force-pushed
the
internal-push-meta-terms-filter
branch
from
ad7f3c1
to
bd8e8a9
Compare
|
Build is passing now. Unit tests needed to return an ID property from the get_post mock to avoid warnings. |
|
Thank @rmarscher! Could you please fix the conflict in |
dinhtungdu
approved these changes
Mar 27, 2020
|
Please hold the merging, I'm waiting for the 570 to be merged to have final testing. |
|
@dinhtungdu #570 has been merged now, so this is ready for testing again. |
dinhtungdu
previously approved these changes
Apr 13, 2020
There was a problem hiding this comment.
Both push and pull worked in my test. No error or warning. Tests are passed here: https://travis-ci.org/github/dinhtungdu/distributor/builds/674211646
|
Thanks for working on merging this. Sorry I was unable to look at it when requested. 🏆 |
dkotter
previously approved these changes
May 29, 2020
dkotter
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the internal connection push method to prepare WP_Post objects in the same way as done by the pull method. This enables the post meta to be filtered when pushing which allows for a workaround to #168 .
I added a
@sincetag to the new\Distributor\Utils\prepare_post()function that will probably need to be edited. This may need to be part of a minor version bump instead of a patch bump since it slightly affects people already using the dt_push_post_args filter - but it seems pretty unlikely that it would cause an issue.