Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in variable name #420

Merged
merged 1 commit into from
Jul 8, 2019
Merged

Typo in variable name #420

merged 1 commit into from
Jul 8, 2019

Conversation

mrazzari
Copy link
Contributor

@mrazzari mrazzari commented Jul 2, 2019

Undefined variable "new_post" should be "new_post_id".

Description of the Change

Variable throws a PHP notice as undefined. This change just renames it as needed.

Undefined variable "new_post" should be "new_post_id".
@jeffpaul jeffpaul added the type:bug Something isn't working. label Jul 2, 2019
@jeffpaul jeffpaul added this to the 1.5.0 milestone Jul 2, 2019
@jeffpaul jeffpaul requested a review from helen July 2, 2019 23:46
@jeffpaul
Copy link
Member

jeffpaul commented Jul 2, 2019

@mrazzari welcome to Distributor and thanks for the PR, I've set this for review in our upcoming 1.5.0 milestone and will get back to you with any questions then, thanks!

@adamsilverstein adamsilverstein self-requested a review July 8, 2019 18:40
@adamsilverstein
Copy link

Thanks for your contribution @mrazzari! Good catch!

Looks like this happened between #149 and #150 getting merged near each other.

Copy link

@adamsilverstein adamsilverstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@adamsilverstein adamsilverstein removed the request for review from helen July 8, 2019 18:52
@adamsilverstein
Copy link

Changelog entry:

  • Correct a mismatched variable name throwing and undefined error.

@helen helen merged commit 000ee3e into 10up:develop Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants