Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AppPwds caveat to external connections set up steps in README.md #544

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

jeffpaul
Copy link
Member

Description of the Change

This PR adds a note to the External Connections set up steps to be more clear about WHY we recommend the use of Application Passwords.

Alternate Designs

Keep as-is so docs are shorter?

Benefits

Ensures we're clear on the reasons we recommend using the App Pwds plugin.

Possible Drawbacks

Longer set up docs means some folks just won't read it entirely?

Verification Process

Manually verified via the GitHub web UI.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

n/a

Changelog Entry

### Added
- Clarification on Application Passwords usage within External Connections setup (props @petenelson)

@jeffpaul jeffpaul added the needs:documentation This requires documentation. label Mar 12, 2020
@jeffpaul jeffpaul added this to the 2.0.0 milestone Mar 12, 2020
@jeffpaul jeffpaul self-assigned this Mar 12, 2020
Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jeffpaul jeffpaul merged commit 6cef51c into develop Mar 12, 2020
@jeffpaul jeffpaul deleted the update/ext-connection-docs branch June 30, 2020 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:documentation This requires documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants