Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue status taxonomy labels added #112

Merged
merged 2 commits into from Feb 27, 2023
Merged

Issue status taxonomy labels added #112

merged 2 commits into from Feb 27, 2023

Conversation

jayedul
Copy link
Contributor

@jayedul jayedul commented Feb 21, 2023

Description of the Change

Issue status taxonomy CRUD labels added.

  • view_item
  • add_or_remove_items
  • name_field_description
  • slug_field_description
  • parent_field_description
  • popular_items
  • parent_item
  • parent_item_colon
  • no_terms
  • back_to_items

Closes #85

How to test the Change

  • Translate or edit these texts in code
  • Check if the modified texts appear in Issue Status term edit screen.

Changelog Entry

Added - Issue Status taxonomy CRUD labels

Credits

Props @jayedul

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jayedul jayedul requested a review from a team as a code owner February 21, 2023 10:17
@jayedul jayedul requested review from peterwilsoncc and removed request for a team February 21, 2023 10:17
@jayedul jayedul self-assigned this Feb 21, 2023
peterwilsoncc
peterwilsoncc reviewed Feb 23, 2023
View reviewed changes
Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor suggestions due to how the statuses are used in the dashboard.

There's also a change to the package-lock.json that's been included, I suspect in error. Are you able to force push that out of existence?

includes/functions/plugins/issue-status.php Outdated Show resolved Hide resolved
includes/functions/plugins/issue-status.php Outdated Show resolved Hide resolved
@jeffpaul jeffpaul added this to the 1.3.0 milestone Feb 23, 2023
peterwilsoncc
peterwilsoncc approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jeffpaul jeffpaul merged commit 113f61b into develop Feb 27, 2023
@jeffpaul jeffpaul deleted the fix/85 branch February 27, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterwilsoncc peterwilsoncc peterwilsoncc approved these changes

Assignees

@jayedul jayedul

Labels
None yet
Projects
None yet
Milestone
1.2.2
Development

Successfully merging this pull request may close these issues.

Update taxonomy lables to include field descriptions, back links, etc
3 participants
@jayedul @peterwilsoncc @jeffpaul