Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a more robust method of disabling collapsing the publish box #37

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

helen
Copy link
Contributor

@helen helen commented Jul 30, 2019

Description of the Change

Instead of removing the postbox class which has side effects beyond the intention, specifically target the arrow (handlediv) and remove the click handler that allows collapsing the metabox.

Alternate Designs

n/a

Benefits

No more UI cruft.

Possible Drawbacks

Possible for it to stop working in a future core update, as already happened with the previous method. However, it should not cause UI cruft.

Verification Process

Manual testing.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Fixes #36

@helen helen added this to the 1.1.0 milestone Jul 30, 2019
@helen helen self-assigned this Jul 30, 2019
Copy link

@adamsilverstein adamsilverstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@helen helen merged commit 5293791 into develop Jul 30, 2019
@jeffpaul jeffpaul deleted the fix/publish-box-ui branch September 30, 2020 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Publish" metabox toggle becomes disconnected
2 participants