Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency-review.yml #164

Merged
merged 7 commits into from
Nov 17, 2022
Merged

Conversation

jeffpaul
Copy link
Member

Description of the Change

This follows on from #157 & 10up/.github#24 to utilize an org-wide config file for the license scanning action to ensure we're utilizing GPL-compatible dependencies.

How to test the Change

Will see if the dependency check runs correctly in the PR, iterate until it does (maybe the config file link needs to be to the raw file?).

Changelog Entry

Changed - license scanning to use org-wide config file.

Credits

Props @jeffpaul.

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jeffpaul
Copy link
Member Author

Managed to get this working after updating the format structure in the external config file (https://github.com/10up/.github/blob/trunk/.github/dependency-review-config.yml)

@jeffpaul
Copy link
Member Author

@Sidsector9 should be a straightforward review/merge to have this run as part of the 1.0.6 release PR to ensure our dependencies are all GPL-compatible. Assuming that goes smoothly, then I'll look to replicate this action across our other repos.

@Sidsector9 Sidsector9 merged commit e94fef0 into develop Nov 17, 2022
@Sidsector9 Sidsector9 deleted the update/license-scanning-config branch November 17, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants