GH action summary added #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffpaul
requested review from
a team and
peterwilsoncc
and removed request for
a team
|
It has been marked as ready for review though some Github action has failed. Failed ones are not related to this PR itself. |
| @@ -55,3 +55,22 @@ jobs: | |||
| run: npm run env:start | |||
| - name: Test | |||
| run: npm run cypress:run | |||
| - name: Update summary | |||
| if: always() | |||
There was a problem hiding this comment.
I pushed this in ddf9924 to ensure the summary displays on failed test runs. See https://github.com/10up/insert-special-characters/actions/runs/4921439734 for an example.
package.json
Outdated
| @@ -46,6 +46,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@wordpress/components": "^22.1.0", | |||
| "cypress-mochawesome-reporter": "^3.4.0", | |||
There was a problem hiding this comment.
I think this should probably be in devDependencies for this repo alongside cypress. In this repo we include the react-character-map from the dependencies in the built version so there may be a risk we include this in the build unintentionally.
Are you able to double check?
peterwilsoncc
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Mochawesome reporter added for Cypress test report
Closes #179
Changelog Entry
Credits
Props @jayedul
Checklist: