Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for grid positioning when text is selected #195

Merged
merged 9 commits into from Jun 21, 2023
Merged

Fix for grid positioning when text is selected #195

merged 9 commits into from Jun 21, 2023

Conversation

bmarshall511
Copy link
Contributor

Description of the Change

This fixes #181, specifically the grid positioning when text is selected.

Closes #181

How to test the Change

Click the character map icon in the toolbar when text is selected.

Changelog Entry

Fixed - Grid positioning when text is selected

Credits

Props @bmarshall511

Checklist:

@bmarshall511 bmarshall511 requested a review from a team as a code owner June 8, 2023 20:34
@bmarshall511 bmarshall511 requested review from peterwilsoncc and removed request for a team June 8, 2023 20:34
@jeffpaul jeffpaul added this to the 1.0.7 milestone Jun 8, 2023
kmgalanakis-sage
kmgalanakis-sage approved these changes Jun 16, 2023
View reviewed changes
Copy link

@kmgalanakis-sage kmgalanakis-sage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise this looks alright, and testing the working branch, it seems that it works as expected.

@dkotter dkotter modified the milestones: 1.0.7, 1.1.0 Jun 16, 2023
peterwilsoncc
peterwilsoncc approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tested in both Chrome and Firefox and the positioning seems to have improved.

@peterwilsoncc peterwilsoncc merged commit 387b7f8 into develop Jun 21, 2023
11 checks passed
@peterwilsoncc peterwilsoncc deleted the fix/grid-positioning-ben branch June 21, 2023 02:20
@bmarshall511 bmarshall511 mentioned this pull request Jun 21, 2023
Closed
1 task
@dkotter dkotter modified the milestones: 1.1.0, 1.0.7 Jun 21, 2023
@jeffpaul jeffpaul linked an issue Jun 22, 2023 that may be closed by this pull request
Core functionality crashes while working with FSE #178
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterwilsoncc peterwilsoncc peterwilsoncc approved these changes

@kmgalanakis-sage kmgalanakis-sage kmgalanakis-sage approved these changes

Assignees

@bmarshall511 bmarshall511

Labels
None yet
Projects
None yet
Milestone
1.0.7
Development

Successfully merging this pull request may close these issues.

CSS display issues in both Firefox and Chrome with v1.0.5 Core functionality crashes while working with FSE
7 participants
@bmarshall511 @peterwilsoncc @kmgalanakis-sage @dkotter @jeffpaul @Sidsector9 @iamdharmesh