Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/34: Add faux cursor to preserve context #207

Merged
merged 11 commits into from Aug 4, 2023
Merged

feat/34: Add faux cursor to preserve context #207

merged 11 commits into from Aug 4, 2023

Conversation

Sidsector9
Copy link
Member

@Sidsector9 Sidsector9 commented Jul 31, 2023

Description of the Change

Closes #34

How to test the Change

  1. Add a post with some content.
  2. Click the insert special characters icon and observe the faux cursor.

Video

Faux cursor

Screen.Recording.2023-08-04.at.5.33.42.PM.mov

Faux text selection

Screen.Recording.2023-08-04.at.7.05.38.PM.mov

Changelog Entry

Added - Faux cursor to preserve context

Credits

Props @helen @Sidsector9

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@Sidsector9 Sidsector9 requested a review from a team as a code owner July 31, 2023 05:47
@Sidsector9 Sidsector9 requested review from peterwilsoncc and removed request for a team July 31, 2023 05:47
@Sidsector9 Sidsector9 self-assigned this Jul 31, 2023
@Sidsector9 Sidsector9 marked this pull request as draft July 31, 2023 11:19
@Sidsector9 Sidsector9 removed the request for review from peterwilsoncc July 31, 2023 11:24
@jeffpaul jeffpaul added this to the 1.1.0 milestone Aug 1, 2023
@jeffpaul jeffpaul requested review from a team and ravinderk and removed request for a team August 1, 2023 12:14
Copy link
Contributor

@ravinderk ravinderk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sidsector9 can you add testing instructions and a screenshot to the pull request?

@Sidsector9 Sidsector9 marked this pull request as ready for review August 4, 2023 13:43
@Sidsector9 Sidsector9 merged commit b2e1873 into develop Aug 4, 2023
10 of 11 checks passed
@Sidsector9 Sidsector9 deleted the feat/34 branch August 4, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show a "cursor" in the editor while popover is open
3 participants