Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/caret: Fix caret and formatting issue #225

Merged
merged 8 commits into from Nov 7, 2023
Merged

Conversation

Sidsector9
Copy link
Member

@Sidsector9 Sidsector9 commented Oct 20, 2023

Description of the Change

Closes #34
Closes #208

How to test the Change

Please see the respective issues for testing instructions.

Changelog Entry

Fixed - Issue with blocks crashing due to faux caret
Fixed - Issue with characters added to the beginning trimming text from the end

Credits

Props @dkotter @Sidsector9

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@Sidsector9 Sidsector9 requested a review from a team as a code owner October 20, 2023 08:15
@Sidsector9 Sidsector9 requested review from peterwilsoncc and removed request for a team October 20, 2023 08:15
@jeffpaul jeffpaul added this to the 1.2.0 milestone Oct 20, 2023
@ankitguptaindia
Copy link
Member

@Sidsector9 This PR fixed the issues reported in both connected issues but I am facing issue in a specific scenario when user select whole content which has any special character.

It is showing This block has encountered an error and cannot be previewed.

Screenshot 2023-10-30 at 10 18 22 PM

Issue.mp4

For QA Use only: RTL Sites:
RTL.mp4

@ankitguptaindia
Copy link
Member

ankitguptaindia commented Nov 4, 2023

QA/Test Report-

Testing Environment -

  • WordPress: 6.5-alpha-57029
  • PHP: 8.0.30
  • Server: nginx/1.16.0
  • Database: mysqli (Server: 5.7.28 / Client: 8.0.30)
  • Browser: Chrome 118.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty-Four 1.0

Actual Results

  • Both Connected issues have been fixed. ✅
  • Issue Reported in QA Feedback has been addressed and fixed. ✅
  • Also tested in RTL & LTR sites, issues have been fixed. ✅
ISC.mp4

@Sidsector9 Sidsector9 merged commit 302fece into develop Nov 7, 2023
11 checks passed
@Sidsector9 Sidsector9 deleted the fix/caret-reversal branch November 7, 2023 15:07
@dkotter dkotter modified the milestones: 1.2.0, 1.1.2 Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants