Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect.js can leave publish button disabled when fields are valid #366

Closed
1 task done
peterwilsoncc opened this issue Feb 15, 2024 · 1 comment · Fixed by #369
Closed
1 task done

Redirect.js can leave publish button disabled when fields are valid #366

peterwilsoncc opened this issue Feb 15, 2024 · 1 comment · Fixed by #369
Assignees
Labels
help wanted type:bug Something isn’t working. type:good-first-issue Good for newcomers.
Milestone

Comments

@peterwilsoncc
Copy link
Contributor

Describe the bug

As the redirect.js file uses the change event to detect whether fields are valid, it requires users click out of the box before detecting the field has been filled out.

This can lead to confusion as the publish button remains disabled when the redirect fields have valid data, the user needs to click out of the field and then click the publish button.

This was reported in #364 (comment) (props @JosVelasco).

Steps to Reproduce

  1. Change the redirect status code to 301
  2. Click in to the redirect from to field
  3. Type then delete some text
  4. Click out of the redirect from field
  5. The publish button should be disabled
  6. Click in to the redirect from field
  7. Type something, do NOT click out of the box
  8. The publish button will remain disabled.

Screenshots, screen recording, code snippet

No response

Environment information

  • Device: Macbook
  • Browser: Firefox 122/macOS 12.7.3

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@peterwilsoncc peterwilsoncc added the type:bug Something isn’t working. label Feb 15, 2024
@jeffpaul jeffpaul added this to the Future Release milestone Feb 15, 2024
@BhargavBhandari90
Copy link
Contributor

Hi Plugin Author,

I would like to work on this issue.

BhargavBhandari90 added a commit to BhargavBhandari90/safe-redirect-manager that referenced this issue Feb 24, 2024
BhargavBhandari90 added a commit to BhargavBhandari90/safe-redirect-manager that referenced this issue Feb 25, 2024
BhargavBhandari90 added a commit to BhargavBhandari90/safe-redirect-manager that referenced this issue Feb 26, 2024
Sidsector9 added a commit that referenced this issue Jun 18, 2024
Issue #366 - Make URL validation on input event instead of change event
@jeffpaul jeffpaul modified the milestones: Future Release, 2.1.2 Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted type:bug Something isn’t working. type:good-first-issue Good for newcomers.
Projects
Archived in project
3 participants