Only public post types will be selectable in the autocomplete Redirect To field

[bmarshall511]

Description of the Change

Autocomplete will now only display public post types.

Closes #331

How to test the Change

1. Go to add a new redirect page (/wp-admin/post-new.php?post_type=redirect_rule)
2. Start typing in the "Redirect To" field
3. Only public post types should be displayed

Changelog Entry

Fixed - Only public post types will be selectable in the autocomplete Redirect To field

Credits

Props @bmarshall511

Checklist:

• I agree to follow this project's Code of Conduct.

[dkotter]

So I know this has already been merged in but I think the better approach here is to use the is_post_type_viewable function to filter the post types (see 10up/distributor@4b8b77e and 10up/distributor#907 (comment)).

So something like:

'post_type' => array_filter( get_post_types(), 'is_post_type_viewable' )

This checks for both the public argument and the publicly_queryable argument

[ravinderk]

Existing query:

@dkotter I am getting the following result with the above code.
I think redirect_rule should not display in the list.

What do you think?

[dkotter]

Yeah, doesn't make sense to show redirect rules within the redirect field. We can either unset that post type (see again Distributor: https://github.com/10up/distributor/pull/907/files#diff-a4c20b6d7391a224faf11e6161c80b408e2a0f5a71a92dc11b7eafe3cad83f94R320) or utilize the is_post_type_viewable core filter to remove the redirect_rule post type from showing (which would impact anyone else using this function, may or may not be a good thing)