Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor update to how autocomplete pulls public post types using is_post_type_viewable #333

Merged
merged 3 commits into from Jun 30, 2023
Merged

Minor update to how autocomplete pulls public post types using is_post_type_viewable #333

merged 3 commits into from Jun 30, 2023

Conversation

bmarshall511
Copy link
Contributor

Description of the Change

Minor update to how autocomplete pulls public post types using is_post_type_viewable, see #332 (comment)

Closes #331

How to test the Change

  1. Go to add a new redirect page (/wp-admin/post-new.php?post_type=redirect_rule)
  2. Start typing in the "Redirect To" field
  3. Only public post types should be displayed

Changelog Entry

Fixed - Update to how post types are pulled in the autocomplete using is_post_type_viewable

Credits

Props @bmarshall511, @dkotter

Checklist:

@bmarshall511 bmarshall511 requested a review from a team as a code owner June 30, 2023 16:43
@bmarshall511 bmarshall511 self-assigned this Jun 30, 2023
@bmarshall511 bmarshall511 requested review from Sidsector9 and removed request for a team June 30, 2023 16:43
@jeffpaul jeffpaul added this to the 2.1.0 milestone Jun 30, 2023
dkotter
dkotter requested changes Jun 30, 2023
View reviewed changes
inc/classes/class-srm-post-type.php Outdated Show resolved Hide resolved
@dkotter dkotter merged commit eeadd8f into develop Jun 30, 2023
11 checks passed
@dkotter dkotter deleted the fix/331-ben branch June 30, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkotter dkotter dkotter approved these changes

@Sidsector9 Sidsector9 Awaiting requested review from Sidsector9 Sidsector9 was automatically assigned from 10up/open-source-practice

Assignees

@bmarshall511 bmarshall511

Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Show publicly available post types in autocomplete dropdown for Redirect To
3 participants
@bmarshall511 @dkotter @jeffpaul