Translation ready #131
Merged
Translation ready #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadic
requested review from
a team and
dkotter
and removed request for
a team
dkotter
requested changes
Dec 21, 2021
| @@ -400,7 +400,7 @@ function add_podcasting_term_meta_nonce( $term, $taxonomy = false ) { | |||
|
|
|||
| if ( $taxonomy ) { | |||
| $url = get_term_feed_link( $term->term_id, TAXONOMY_NAME ); | |||
| __( 'Your Podcast Feed:', 'ads-txt' ); | |||
| __( 'Your Podcast Feed:', 'simple-podcasting' ); | |||
There was a problem hiding this comment.
Does this actually output? Maybe I'm missing something here but I'm not actually seeing an echo statement around this so seems like this won't ever display. If so, this should probably be esc_html_e
dkotter
previously approved these changes
Dec 21, 2021
|
@dkotter one last change to resolve merge conflicts in package.json |
dkotter
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Closes #130
Fixed number of missing/incorrect text-domain strings, added POT file compile to the build process.
Verification Process
Checklist:
Changelog Entry
Added - Auto-create pot file in languages folder during the build process
Fixed - Missing and incorrect text-domain
Credits
Props @cadic