This repository has been archived by the owner on May 2, 2022. It is now read-only.
Feature/gulp4 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timwright12
suggested changes
May 18, 2018
package.json
Outdated
| "gulp-cssnano": "^2.1.2", | ||
| "gulp-filter": "^5.1.0", | ||
| "gulp-livereload": "^3.8.1", | ||
| "gulp-postcss": "^7.0.1", | ||
| "gulp-rename": "^1.2.2", | ||
| "gulp-sass": "^3.2.1", |
There was a problem hiding this comment.
we're not using Sass, you can remove this
|
@asvinb can you take a look at this when you get a chance? Let's also make sure that any updates here are also reflected in the plugin scaffold: https://github.com/10up/plugin-scaffold |
added 4 commits
June 18, 2018 19:37
* master: (23 commits) updated ignore for config files Updating README.md and excluding dirs from eslint added node engine to package moved eslint to npm package moved eslint to npm package Fix spacing according to .editorconfig Add .browserslistrc to .editorconfig to match plugin scaffold working postcss-env Add all the find/replace options added browserslist updated package documentation Adding husky and lint-stage to ensure commits pass linting Add composer command to "deploy" to bring this inline with the plugin repo Add support for Composer installer-paths Improve inline docs for requiring autoloader Removed PHPDoc @uses, @SInCE, and @Package Uncomment feature & primary menu declarations removed package lock and upadated readme update cssnext updated ReadMe ...
|
@timwright12 I made the changes you requested and fixed the merge conflicts. Can you check it out again? Thanks! |
timwright12
approved these changes
Jun 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@timwright12 This PR is to upgrade Gulp3 to Gulp4. I compared the build time between the 2 and noticed the v4 version is slightly faster (15%).
V3: https://gist.github.com/asvinb/35a0cad0adf7a42d81c1a2ac176b84c8
V4: https://gist.github.com/asvinb/0e21be00c1384c5323834bbefe901aca
The tests are in my repo:
https://github.com/asvinb/theme-scaffold/tree/tests/gulp3
https://github.com/asvinb/theme-scaffold/tree/tests/gulp4
Let me know what you think :)