Feature/19138441 tailwind v3 testing #160
Conversation
Nikki-Jones
changed the base branch from
bug/19141384-tailwind-v3-pr-fixes
to
epic/tailwind-v3
There was a problem hiding this comment.
@Nikki-Jones some great additions here, really stoked! 👍🏻 from me!
There was a problem hiding this comment.
@Nikki-Jones I'm glad you were able to get this put together and there's some great stuff in here to help tighten up the DX/ergonomics.
I have 1-2 things that I would like to get the team's take on before we merge this and make sure we're all on the same page, and I believe there's perhaps a few small cleanup items as well.
I tried to leave some detailed feedback just let me know if you (or anyone else) want to talk through anything.
There was a problem hiding this comment.
Lookin pretty nice! I just had one point of discussion I wanted to get the group's take on but otherwise I'm with it!
I really love the attention to detail on this CSS reset (the default normalize is...not great even in the best of scenarios).
Really nice work here.
| @layer components { | ||
|
|
||
| } |
There was a problem hiding this comment.
@iansvo @Nikki-Jones I don't know if we've tried this so let me know if I'm crazy, have we combined @layer and @import? I realize why we'd want a layer, but I'm just thinking about if a engineer wants a lot of their own components.
There was a problem hiding this comment.
Hey @Firestorm980, could you add an example?
There was a problem hiding this comment.
@Nikki-Jones So, for example, let's say I have 10+ custom components. Would I do:
@layer components {
@import url('components/card');
@import url('components/select');
/* ... a bunch of other imports */
}Or, something else? (It occurs to me you may @import and then use @layer in the component itself.)
And to be clear, I'm not saying something is wrong with this code, more an implementation question that you may or may not have the answer to.
Description of the Change
After using Tailwind with 10up Toolkit on a real project there were some changes made to the base configuration. These modification help Wordpress Gutenberg styling from conflicting with Tailwind's reset. The developer experience is also improved with the addition of Stylelint and nesting.
Changelog Entry
Checklist: