Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

PUT requests don't work #70

Closed
xanoinc opened this issue May 17, 2021 · 1 comment
Closed

PUT requests don't work #70

xanoinc opened this issue May 17, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@xanoinc
Copy link

xanoinc commented May 17, 2021

Description
PUT requests appear to be broken.

Trying to use client.updateWatchlist complains about a malformed request.

It looks like there is a conditional in the request method that needs to be updated

CURRENT: if (params.method != 'POST' && params.method != 'PATCH') {
CHANGE TO: if (!['POST','PATCH','PUT'].includes(params.method)) {

Expected
A clear and concise description of what you expected to happen.

The watchlist should get updated properly.

Reproduction
Steps we can take to reproduce the bug:

Just try using client.updateWatchlist and it will generate an error from the server due to a malformed request.

Logs
If applicable, add logs to help explain the bug.

Additional
Add any other context about the problem here.

@xanoinc xanoinc added the bug Something isn't working label May 17, 2021
117 added a commit that referenced this issue May 18, 2021
@117
Copy link
Contributor

117 commented May 18, 2021

Thank you for finding the issue.

@117 117 closed this as completed May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants