Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I migrated the site to Jekyll!
default.html
(for the main site), andbare.html
(for the linking policy and thank you page).<meta refresh>
tag. The "you will be redirected" copy was moved up next to the main content.href="/js/18f.min.js"
and nothref="js/18f.min.js"
)./thank-you/
instead of/thank-you.html
. Same for linking policy. It seems early enough, and these pages not so important, that this should be fine.This is based off of the
devel
branch, so some other un-deployed changes are present, such as removing Lena and the addition of a link to our open source policy.Now that we're using absolute URLs, it means the site can't run behind a path prefix anymore (like our current staging area at 18f.github.io/18f-staging has been) -- and, we want to keep our options of using non-GitHub-Pages-supported Jekyll plugins open, so we need to use a non-GHP staging area. I will need to update our deploy server to set up a staging path and a production path.
Future development items
<meta>
tags now) into the site's_config.yml
.jquery.dotdotdot
, and remove the use ofgit submodules
.team.yml
data file - this will also let us refactor how we display teammates much, much easier.<rel = "canonical">
links at the top of pages.jekyll
builds without errors.staging.18f.us
at the same box, so we can use that as the staging URL instead of18f.github.io/staging
. (The staging repo can be deleted at that point, I believe.)But I don't think any of these are standing in the way of the merge -- the deploy details can be taken care of post-merge and out-of-repo, and the site here is as good as it is on https://18f.gsa.gov right now.