Admin Analytics: CSV Downloads broken #173
Comments
GUI
added a commit
to NREL/api-umbrella-web
that referenced
this issue
Jan 18, 2015
See: 18F/api.data.gov#173 When we updated DataTables to 1.10 and the new ajax standard (http://datatables.net/manual/server-side), we began to have conflicts over their concept of the "start" param being for pagination, and our use of "start" parameter being for date ranges. We had sort of solved it by renaming the parameter differently depending on the use-case, but this got to be confusing. This is also what partially broke the CSV downloads, since the query parameter names had gotten out of sync. This fixes all of that by letting DataTables take the "start" parameter, and we've renamed our date parameters to be "start_at" and "end_at". This removes the conflict and makes things a little more sane. There were other aspects of the CSV download that were also broken from when we switched to the official elasticsearch ruby client. Those are also fixed now. And finally, we've finally begun to add some very initial tests to the analytics area, so we're actually testing our elasticsearch queries. Tests are now present for the CSV download link to hopefully make sure this doesn't happen again.
|
This should be fixed in NREL/api-umbrella-web@6420c24 See the comment on the commit for more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the admin analytics pages, you can download the complete results on most pages by clicking the "Download CSV" link in the bottom left corner. However, these links are currently returning errors.
The culprit seems to be related to the start/end time query parameters in the URL. In the download link the query parameters are
startandend. If those get replaced withstart_timeandend_time, the download link works. But I'm a bit confused, and this needs further investigation because on the results page in the admin UI, we do usestartandend(and the download URL parameters should generally match those). There's obviously a discrepancy between these parameter names somewhere we should cleanup.We should also figure out why our test suite didn't catch this, since I recall fixing broken downloads before.
The text was updated successfully, but these errors were encountered: