Add links for Logs and Events #298
Conversation
|
@jeremiak Check that there should actually be events for the app in question from the CLI: |
|
This looks good, waiting for you to check what Bret said. I also re-ran the tests because it was a random failure. |
|
Coverage remained the same at 72.599% when pulling 22450967473286a85a2ae69809144f26186b0be6 on jk-add-logs-links into ffb4003 on staging-alpha. |
jeremiak
force-pushed
the
jk-add-logs-links
branch
from
2245096
to
4de0b8d
Compare
Generate links to Kibana for both app logs and app events. Currently, both links set "Year to date" as the time query for the report. This increases the liklihood that the user will see a message instead of the default of "Last 15 minutes".
jeremiak
force-pushed
the
jk-add-logs-links
branch
from
4de0b8d
to
7adb048
Compare
jeremiak
changed the title
|
Here's a screenshot of the current view: This is technically ready for review @msecret. Both the logs and events links should go to the proper view on Kibana, with the time bounds set by default to year to date to help ensure that there will be data for the user to look at. I wanted to raise the issue of the current text not being super helpful to users who don't already have context on what the difference between an "event" and the regular "logs" are. Indeed, I'm not quite sure of this difference myself. @mogul anywhere I can grab some text on what an event is and how it differs from the other logs? |
|
@jeremiak said:
I don't see any good summary in the CF docs, so maybe distill what you see in this SO answer? |
This PR adds a link for the current logs view of the application. There is no way to embed an iframe until we resolve cloud-gov/logsearch-for-cloudfoundry#5, so in the meantime we are using plain links to direct users to the proper places on logs.cloud.gov. Screenshot:
Right now, the "Logs" link works but I'm having issues with the "Events" link. I'm not quite sure what it should link to. When I follow @mogul's instructions I get an empty dashboard. Screenshot:
The instructions I am referencing are:
Refs #289