Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🟢 fetch homework doesn't work with the provided files #332

Open
Tracked by #376
edwintorres opened this issue Mar 26, 2021 · 3 comments
Open
Tracked by #376

🟢 fetch homework doesn't work with the provided files #332

edwintorres opened this issue Mar 26, 2021 · 3 comments
Labels
bug Something isn't working Engineering Hiring Task related to the Engineering Hiring Guide +/or pulled from the old Engineering Hiring Guide repo. Guides Initiative 2 Tracks work for "Improving the Maintainability of the 18F Guides and Methods"

Comments

@edwintorres
Copy link
Member

The fetch assignment doesn't work with the provided files. The candidates need to changes the version of a dependency and add a new dependency just to start with the assignment. For example, a candidate I interviewed did not finish his assignment because he struggled to fix it. In the end, he submitted a pseudo-code. I was not sure how to evaluate him because fix the project was not part of the homework.

@mark-meyer
Copy link
Member

mark-meyer commented Mar 28, 2021

Any idea which dependency is causing the issue? I was able to download the zip file and run:

(base) fetch % yarn install             
yarn install v1.22.10
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 🔨  Building fresh packages...
✨  Done in 29.05s.

Then with some quick and dirty code do:

(base)  fetch % yarn test
yarn run v1.22.10
$ sh ./test/test.sh
Records API listening on port 3000!
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db
ℹ 「wdm」: Hash: b84017bab94ec4178914
Version: webpack 4.44.1
Time: 823ms
Built at: 03/28/2021 1:41:38 PM
                          Asset      Size                        Chunks             Chunk Names
                        main.js  1.12 MiB                          main  [emitted]  main
test/api/managed-record-test.js   349 KiB  test/api/managed-record-test  [emitted]  test/api/managed-record-test
Entrypoint main = main.js
Entrypoint test/api/managed-record-test = test/api/managed-record-test.js
[0] multi @babel/polyfill ./index.js 40 bytes {main}
[./api/managed-records.js] 4.98 KiB {main} {test/api/managed-record-test} [built]
[./index.js] 66 bytes {main} [built]
[./node_modules/@babel/polyfill/lib/index.js] 686 bytes {main} [built]
[./node_modules/@babel/polyfill/lib/noConflict.js] 567 bytes {main} [built]
[./node_modules/core-js/es6/index.js] 5.78 KiB {main} [built]
[./node_modules/core-js/fn/array/flat-map.js] 108 bytes {main} [built]
[./node_modules/core-js/library/fn/global.js] 87 bytes {main} [built]
[./node_modules/fetch-ponyfill/build/fetch-browser.js] 15.9 KiB {main} {test/api/managed-record-test} [built]
[./node_modules/urijs/src/IPv6.js] 4.32 KiB {main} {test/api/managed-record-test} [built]
[./node_modules/urijs/src/SecondLevelDomains.js] 11.8 KiB {main} {test/api/managed-record-test} [built]
[./node_modules/urijs/src/URI.js] 64.7 KiB {main} {test/api/managed-record-test} [built]
[./node_modules/urijs/src/punycode.js] 14.3 KiB {main} {test/api/managed-record-test} [built]
[./test/api/managed-record-test.js] 9.15 KiB {test/api/managed-record-test} [built]
[./util/fetch-fill.js] 136 bytes {main} {test/api/managed-record-test} [built]
    + 304 hidden modules
ℹ 「wdm」: Compiled successfully.
...........
PhantomJS 2.1.1 (Mac OS 0.0.0): Executed 11 of 11 SUCCESS (0.178 secs / 0.175 secs)
✨  Done in 6.29s.

This is on my personal mac with os 11.2.3 and node v12.18.3.

@edwintorres
Copy link
Member Author

I'm going to test this again. Today's candidate told me he had no issues. When I did this exercise months ago I did have problems with the jasmine and karma version. I had to change it from "jasmine-core": "3.6.0" to "jasmine-core": "^2.4.1" and "karma": "5.1.1" to "karma": "^1.7.0". I was using a Windows machine.

@hbillings
Copy link
Member

I think we've established now that this is a Windows-specific issue. Hoping to get at least some guidance for addressing this up on the hiring guide before our next round!

@alexsobledotgov alexsobledotgov added the bug Something isn't working label Jan 20, 2023
@christophermather christophermather transferred this issue from 18F/eng-hiring Dec 20, 2023
@christophermather christophermather added the Engineering Hiring Task related to the Engineering Hiring Guide +/or pulled from the old Engineering Hiring Guide repo. label Dec 20, 2023
@christophermather christophermather added Initiative 2 Tracks work for "Improving the Maintainability of the 18F Guides and Methods" Guides labels Dec 22, 2023
@amymok amymok changed the title fetch homework doesn't work with the provided files 🟢 fetch homework doesn't work with the provided files Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Engineering Hiring Task related to the Engineering Hiring Guide +/or pulled from the old Engineering Hiring Guide repo. Guides Initiative 2 Tracks work for "Improving the Maintainability of the 18F Guides and Methods"
Projects
None yet
Development

No branches or pull requests

5 participants