-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuration of available locales #10472
Conversation
changelog: Internal, Configuration, Allow configuration of available locales
I was trying to find any places in code we hard-code locales. While I didn't find any that reference the list, I did find this code, which is something we'll want to plan around as we add more locales. Maybe we can add a test that fails if the set of locales that it switches on is different from identity-idp/lib/telephony/pinpoint/voice_sender.rb Lines 100 to 111 in c8e7a0d
|
Thanks for catching that. Refactored to add a test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 馃憤
I found another place we have hardcoded lists of locales. Can this be updated to reference the configuration? Or have a test similar to what was added for identity-idp/config/initializers/rack_attack.rb Lines 11 to 13 in 1d769f7
|
馃洜 Summary of changes
As we move towards supporting more languages, we will want to be able to enable locales per-environment so that we can continue working on content without yet displaying to end users.