LG-12553: A/B Test for 10-digit IdV OTP #10480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solipet
force-pushed
the
dprice-lg-12553-ab-test-10-digit-otp
branch
2 times, most recently
from
7b56441
to
4f0ba13
Compare
zachmargolis
approved these changes
Apr 30, 2024
matthinz
requested changes
Apr 30, 2024
There was a problem hiding this comment.
I just noticed that the phone call text references "your 6-character Login.gov one-time code," which I think needs to be "your 10-digit Login.gov one-time code"
<speak>
<prosody rate='slow'>
Hello! Your 6-character Login.gov one-time code is,
9 <break time='0.5s' />
0 <break time='0.5s' />
1 <break time='0.5s' />
0 <break time='0.5s' />
1 <break time='0.5s' />
8 <break time='0.5s' />
0 <break time='0.5s' />
9 <break time='0.5s' />
8 <break time='0.5s' />
0 <break time='0.5s' /> .
Your one-time code is,
9 <break time='0.5s' />
0 <break time='0.5s' />
1 <break time='0.5s' />
0 <break time='0.5s' />
1 <break time='0.5s' />
8 <break time='0.5s' />
0 <break time='0.5s' />
9 <break time='0.5s' />
8 <break time='0.5s' />
0 <break time='0.5s' /> .
Again, your one-time code is
9 <break time='0.5s' />
0 <break time='0.5s' />
1 <break time='0.5s' />
0 <break time='0.5s' />
1 <break time='0.5s' />
8 <break time='0.5s' />
0 <break time='0.5s' />
9 <break time='0.5s' />
8 <break time='0.5s' />
0 <break time='0.5s' /> .
This code expires in 10 minutes.
</prosody>
</speak>
I am assuming these messages are localized, but am not totally sure. I would say we should either change "6-character" to "10-digit" here or remove the "6-character" altogether
|
Also, I'm getting a front end error trying to submit the code:
|
It is, yep: identity-idp/config/locales/telephony/en.yml Lines 25 to 27 in 3dac4df |
Great catch! updated in 4ca6cba |
This PR sets up an A/B test where one group gets the current six alphanumeric character OTP, and the other group gets the new ten numeric digit OTP under test. The test bucket they are put in is logged in all IdV events. changelog: User-Facing Improvements, Identity Verification, A/B test to try out 10-digit OTP for Identity Verification
solipet
force-pushed
the
dprice-lg-12553-ab-test-10-digit-otp
branch
from
9f973dd
to
b8d4d4c
Compare
Merged
jmdembe
pushed a commit
that referenced
this pull request
May 7, 2024
* LG-12553: A/B Test for 10-digit IdV OTP This PR sets up an A/B test where one group gets the current six alphanumeric character OTP, and the other group gets the new ten numeric digit OTP under test. The test bucket they are put in is logged in most IdV events. changelog: User-Facing Improvements, Identity Verification, A/B test to try out 10-digit voice OTP for Identity Verification
jmhooper
added a commit
that referenced
this pull request
May 23, 2024
In #10480 we added an A/B test that made voice OTPs 10-digits for IdV users for some percentage of users. This was to test whether a 10-digit numeric code sees more success than a 6-digit alphanumeric code. This included a change to the message for the voice OTP since the message includes the length, e.g. "Your 10-digit Login.gov one time code is 1234567890". The translation for the 10-digit code was erroneously applied to 6-digit codes when auth users chose voice calls to confirm phones during sign up. This commit fixes that issue. [skip changelog]
jmhooper
added a commit
that referenced
this pull request
May 23, 2024
…auth (#10694) In #10480 we added an A/B test that made voice OTPs 10-digits for IdV users for some percentage of users. This was to test whether a 10-digit numeric code sees more success than a 6-digit alphanumeric code. This included a change to the message for the voice OTP since the message includes the length, e.g. "Your 10-digit Login.gov one time code is 1234567890". The translation for the 10-digit code was erroneously applied to 6-digit codes when auth users chose voice calls to confirm phones during sign up. This commit fixes that issue. [skip changelog]
mitchellhenke
pushed a commit
that referenced
this pull request
May 28, 2024
…auth (#10694) In #10480 we added an A/B test that made voice OTPs 10-digits for IdV users for some percentage of users. This was to test whether a 10-digit numeric code sees more success than a 6-digit alphanumeric code. This included a change to the message for the voice OTP since the message includes the length, e.g. "Your 10-digit Login.gov one time code is 1234567890". The translation for the 10-digit code was erroneously applied to 6-digit codes when auth users chose voice calls to confirm phones during sign up. This commit fixes that issue. [skip changelog]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-12553
🛠 Summary of changes
This PR sets up an A/B test where one group gets the current six
alphanumeric character OTP, and the other group gets the new ten numeric
digit OTP under test.
The test bucket they are put in is logged in all IdV events.