Use Capybara's #find to enter the password #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why**: Sometimes, there is a delay long enough between when Capybara clicks the confirmation link in the user's email and when the password page appears, that causes `sign_up_and_2fa_as_a_user_would` to fail intermittently on Travis. **How**: Modify the spec such that Capybara waits (up to the `default_max_wait_time`) for the element to appear. This can be done by using the `find` method (which incorporates waiting by default, unlike `fill_in`) or adding a presence expectation for any element on the screen before attempting to fill in the password field. I opted for the former.
amoose
pushed a commit
that referenced
this pull request
Feb 7, 2017
**Why**: Sometimes, there is a delay long enough between when Capybara clicks the confirmation link in the user's email and when the password page appears, that causes `sign_up_and_2fa_as_a_user_would` to fail intermittently on Travis. **How**: Modify the spec such that Capybara waits (up to the `default_max_wait_time`) for the element to appear. This can be done by using the `find` method (which incorporates waiting by default, unlike `fill_in`) or adding a presence expectation for any element on the screen before attempting to fill in the password field. I opted for the former.
amoose
pushed a commit
that referenced
this pull request
Feb 24, 2017
**Why**: Sometimes, there is a delay long enough between when Capybara clicks the confirmation link in the user's email and when the password page appears, that causes `sign_up_and_2fa_as_a_user_would` to fail intermittently on Travis. **How**: Modify the spec such that Capybara waits (up to the `default_max_wait_time`) for the element to appear. This can be done by using the `find` method (which incorporates waiting by default, unlike `fill_in`) or adding a presence expectation for any element on the screen before attempting to fill in the password field. I opted for the former.
amoose
pushed a commit
that referenced
this pull request
Feb 28, 2017
**Why**: Sometimes, there is a delay long enough between when Capybara clicks the confirmation link in the user's email and when the password page appears, that causes `sign_up_and_2fa_as_a_user_would` to fail intermittently on Travis. **How**: Modify the spec such that Capybara waits (up to the `default_max_wait_time`) for the element to appear. This can be done by using the `find` method (which incorporates waiting by default, unlike `fill_in`) or adding a presence expectation for any element on the screen before attempting to fill in the password field. I opted for the former.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: Sometimes, there is a delay long enough between when Capybara
clicks the confirmation link in the user's email and when the password
page appears, that causes
sign_up_and_2fa_as_a_user_wouldto failintermittently on Travis.
How: Modify the spec such that Capybara waits (up to the
default_max_wait_time) for the element to appear. This can be doneby using the
findmethod (which incorporates waiting by default,unlike
fill_in) or adding a presence expectation for any element onthe screen before attempting to fill in the password field. I opted for
the former.