Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable RSpec/LeakyConstantDeclaration rubocop #9348

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Enable RSpec/LeakyConstantDeclaration rubocop #9348

merged 4 commits into from
Oct 10, 2023

Commits on Oct 10, 2023

  1. Enable RSpec/LeakyConstantDeclaration rubocop 

    changelog: Internal, Source code, Enable RSpec rubocop
    @zachmargolis
    zachmargolis committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    553cecd View commit details
    Browse the repository at this point in the history

  2. Use let instead of defining new class 

    Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
    @mitchellhenke @zachmargolis
    mitchellhenke and zachmargolis committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    3ec2265 View commit details
    Browse the repository at this point in the history

  3. Clean up some more specs

    @zachmargolis
    zachmargolis committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    b30d5e1 View commit details
    Browse the repository at this point in the history

  4. DRY up a controller spec a tad

    @zachmargolis
    zachmargolis committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    bb6cec0 View commit details
    Browse the repository at this point in the history