Enable RSpec/LeakyConstantDeclaration rubocop

.rubocop.yml

@@ -5,6 +5,7 @@
 # https://github.com/bbatsov/rubocop/blob/master/config/disabled.yml
 require:
   - rubocop-rails
+  - rubocop-rspec
   - rubocop-performance
   - ./lib/linters/analytics_event_name_linter.rb
   - ./lib/linters/localized_validation_message_linter.rb
@@ -997,6 +998,9 @@ Rails/WhereNot:
 Rails/WhereNotWithMultipleConditions:
   Enabled: true
 
+RSpec/LeakyConstantDeclaration:
+  Enabled: true
+
 Security/Eval:
   Enabled: true
 

Gemfile

@@ -111,6 +111,7 @@ group :development, :test do
   gem 'rubocop', '~> 1.55.1', require: false
   gem 'rubocop-performance', '~> 1.18.0', require: false
   gem 'rubocop-rails', '>= 2.5.2', require: false
+  gem 'rubocop-rspec', require: false
 end
 
 group :test do

Gemfile.lock

@@ -596,13 +596,21 @@ GEM
       unicode-display_width (>= 2.4.0, < 3.0)
     rubocop-ast (1.29.0)
       parser (>= 3.2.1.0)
+    rubocop-capybara (2.19.0)
+      rubocop (~> 1.41)
+    rubocop-factory_bot (2.24.0)
+      rubocop (~> 1.33)
     rubocop-performance (1.18.0)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
     rubocop-rails (2.20.2)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.33.0, < 2.0)
+    rubocop-rspec (2.24.1)
+      rubocop (~> 1.33)
+      rubocop-capybara (~> 2.17)
+      rubocop-factory_bot (~> 2.22)
     ruby-progressbar (1.13.0)
     ruby-saml (1.13.0)
       nokogiri (>= 1.10.5)
@@ -805,6 +813,7 @@ DEPENDENCIES
   rubocop (~> 1.55.1)
   rubocop-performance (~> 1.18.0)
   rubocop-rails (>= 2.5.2)
+  rubocop-rspec
   ruby-progressbar
   ruby-saml
   safe_target_blank (>= 1.0.2)

spec/components/base_component_spec.rb

@@ -1,11 +1,13 @@
 require 'rails_helper'
 
 RSpec.describe BaseComponent, type: :component do
+  # rubocop:disable RSpec/LeakyConstantDeclaration
   class ExampleComponent < BaseComponent
     def call
       ''
     end
   end
+  # rubocop:enable RSpec/LeakyConstantDeclaration
 
   let(:view_context) { vc_test_controller.view_context }
 
@@ -20,6 +22,7 @@ def call
   end
 
   context 'with sidecar script' do
+    # rubocop:disable RSpec/LeakyConstantDeclaration
     class ExampleComponentWithScript < BaseComponent
       def call
         ''
@@ -32,7 +35,9 @@ def self.sidecar_files(extensions)
         files.presence || super(extensions)
       end
     end
+    # rubocop:enable RSpec/LeakyConstantDeclaration
 
+    # rubocop:disable RSpec/LeakyConstantDeclaration
     class ExampleComponentWithScriptRenderingOtherComponentWithScript < BaseComponent
       def call
         render(ExampleComponentWithScript.new)
@@ -46,7 +51,9 @@ def self.sidecar_files(extensions)
         end
       end
     end
+    # rubocop:enable RSpec/LeakyConstantDeclaration
 
+    # rubocop:disable RSpec/LeakyConstantDeclaration
     class NestedExampleComponentWithScript < ExampleComponentWithScript
       def self.sidecar_files(extensions)
         if extensions.include?('js')
@@ -56,6 +63,7 @@ def self.sidecar_files(extensions)
         end
       end
     end
+    # rubocop:enable RSpec/LeakyConstantDeclaration
 
     it 'adds script to class variable when rendered' do
       expect(view_context).to receive(:enqueue_component_scripts).with(
@@ -98,6 +106,7 @@ def self.sidecar_files(extensions)
   end
 
   context 'with sidecar stylesheet' do
+    # rubocop:disable RSpec/LeakyConstantDeclaration
     class ExampleComponentWithStylesheet < BaseComponent
       def call
         ''
@@ -109,7 +118,9 @@ def self.sidecar_files(extensions)
         files.presence || super(extensions)
       end
     end
+    # rubocop:enable RSpec/LeakyConstantDeclaration
 
+    # rubocop:disable RSpec/LeakyConstantDeclaration
     class ExampleComponentWithStylesheetRenderingOtherComponentWithStylesheet < BaseComponent
       def call
         render(ExampleComponentWithStylesheet.new)
@@ -123,7 +134,9 @@ def self.sidecar_files(extensions)
         end
       end
     end
+    # rubocop:enable RSpec/LeakyConstantDeclaration
 
+    # rubocop:disable RSpec/LeakyConstantDeclaration
     class NestedExampleComponentWithStylesheet < ExampleComponentWithStylesheet
       def self.sidecar_files(extensions)
         if extensions.include?('scss')
@@ -133,6 +146,7 @@ def self.sidecar_files(extensions)
         end
       end
     end
+    # rubocop:enable RSpec/LeakyConstantDeclaration
 
     it 'adds script to class variable when rendered' do
       expect(view_context).to receive(:enqueue_component_stylesheets).with(

spec/components/block_link_component_spec.rb

@@ -30,6 +30,7 @@
   end
 
   context 'with custom renderer' do
+    # rubocop:disable RSpec/LeakyConstantDeclaration
     class ExampleBlockLinkCustomRendererComponent < BaseComponent
       def initialize(href:, **)
         @href = href
@@ -39,6 +40,7 @@ def call
         content_tag(:button, "Example #{content.strip}", data: { href: @href })
       end
     end
+    # rubocop:enable RSpec/LeakyConstantDeclaration
 
     it 'renders using the custom renderer' do
       rendered = render_inline BlockLinkComponent.new(

spec/controllers/concerns/idv/ab_test_analytics_concern_spec.rb

@@ -1,19 +1,14 @@
 require 'rails_helper'
 
-RSpec.describe 'AbTestAnalyticsConcern' do
-  module Idv
-    class StepController < ApplicationController
-      include AbTestAnalyticsConcern
-    end
-  end
-
+RSpec.describe Idv::AbTestAnalyticsConcern do
   let(:user) { create(:user) }
   let(:idv_session) do
     Idv::Session.new(user_session: subject.user_session, current_user: user, service_provider: nil)
   end
 
   describe '#ab_test_analytics_buckets' do
-    controller Idv::StepController do
+    controller(ApplicationController) do
+      include Idv::AbTestAnalyticsConcern
     end
 
     let(:acuant_sdk_args) { { as_bucket: :as_value } }

spec/controllers/concerns/idv_step_concern_spec.rb

@@ -6,41 +6,43 @@
     Idv::Session.new(user_session: subject.user_session, current_user: user, service_provider: nil)
   end
 
-  module Idv
-    class StepController < ApplicationController
-      include IdvStepConcern
+  idv_step_controller_class = Class.new(ApplicationController) do
+    def self.name
+      'AnonymousController'
+    end
 
-      def show
-        render plain: 'Hello'
-      end
+    include IdvStepConcern
+
+    def show
+      render plain: 'Hello'
     end
   end
 
   describe 'before_actions' do
     it 'includes handle_fraud' do
-      expect(Idv::StepController).to have_actions(
+      expect(idv_step_controller_class).to have_actions(
         :before,
         :handle_fraud,
       )
     end
 
     it 'includes check_for_mail_only_outage before_action' do
-      expect(Idv::StepController).to have_actions(
+      expect(idv_step_controller_class).to have_actions(
         :before,
         :check_for_mail_only_outage,
       )
     end
   end
 
   describe '#confirm_idv_needed' do
-    controller Idv::StepController do
+    controller(idv_step_controller_class) do
       before_action :confirm_idv_needed
     end
 
     before(:each) do
       sign_in(user)
       routes.draw do
-        get 'show' => 'idv/step#show'
+        get 'show' => 'anonymous#show'
       end
     end
 
@@ -73,14 +75,14 @@ def show
   end
 
   describe '#confirm_address_step_complete' do
-    controller Idv::StepController do
+    controller(idv_step_controller_class) do
       before_action :confirm_address_step_complete
     end
 
     before(:each) do
       sign_in(user)
       routes.draw do
-        get 'show' => 'idv/step#show'
+        get 'show' => 'anonymous#show'
       end
     end
 
@@ -131,14 +133,14 @@ def show
   end
 
   describe '#confirm_verify_info_step_complete' do
-    controller Idv::StepController do
+    controller(idv_step_controller_class) do
       before_action :confirm_verify_info_step_complete
     end
 
     before(:each) do
       sign_in(user)
       routes.draw do
-        get 'show' => 'idv/step#show'
+        get 'show' => 'anonymous#show'
       end
     end
 
@@ -185,15 +187,15 @@ def show
   end
 
   describe '#confirm_no_pending_in_person_enrollment' do
-    controller Idv::StepController do
+    controller(idv_step_controller_class) do
       before_action :confirm_no_pending_in_person_enrollment
     end
 
     before(:each) do
       sign_in(user)
       allow(subject).to receive(:current_user).and_return(user)
       routes.draw do
-        get 'show' => 'idv/step#show'
+        get 'show' => 'anonymous#show'
       end
     end
 
@@ -223,15 +225,15 @@ def show
   end
 
   describe '#confirm_no_pending_gpo_profile' do
-    controller Idv::StepController do
+    controller(idv_step_controller_class) do
       before_action :confirm_no_pending_gpo_profile
     end
 
     before(:each) do
       sign_in(user)
       allow(subject).to receive(:current_user).and_return(user)
       routes.draw do
-        get 'show' => 'idv/step#show'
+        get 'show' => 'anonymous#show'
       end
     end
 

spec/controllers/concerns/rate_limit_concern_spec.rb

@@ -3,32 +3,34 @@
 RSpec.describe 'RateLimitConcern' do
   let(:user) { create(:user, :fully_registered, email: 'old_email@example.com') }
 
-  module Idv
-    class StepController < ApplicationController
-      include RateLimitConcern
-      include IdvSession
+  idv_step_controller_class = Class.new(ApplicationController) do
+    def self.name
+      'AnonymousController'
+    end
 
-      def show
-        render plain: 'Hello'
-      end
+    include RateLimitConcern
+    include IdvSession
 
-      def update
-        render plain: 'Bye'
-      end
+    def show
+      render plain: 'Hello'
+    end
+
+    def update
+      render plain: 'Bye'
     end
   end
 
   describe '#confirm_not_rate_limited' do
-    controller Idv::StepController do
+    controller(idv_step_controller_class) do
       before_action :confirm_not_rate_limited
     end
 
     before(:each) do
       sign_in(user)
       allow(subject).to receive(:current_user).and_return(user)
       routes.draw do
-        get 'show' => 'idv/step#show'
-        put 'update' => 'idv/step#update'
+        get 'show' => 'anonymous#show'
+        put 'update' => 'anonymous#update'
       end
     end
 
@@ -100,16 +102,16 @@ def update
   end
 
   describe '#confirm_not_rate_limited_after_doc_auth' do
-    controller Idv::StepController do
+    controller(idv_step_controller_class) do
       before_action :confirm_not_rate_limited_after_doc_auth
     end
 
     before(:each) do
       sign_in(user)
       allow(subject).to receive(:current_user).and_return(user)
       routes.draw do
-        get 'show' => 'idv/step#show'
-        put 'update' => 'idv/step#update'
+        get 'show' => 'anonymous#show'
+        put 'update' => 'anonymous#update'
       end
     end
 
@@ -132,16 +134,16 @@ def update
   end
 
   describe '#confirm_not_rate_limited_after_idv_resolution' do
-    controller Idv::StepController do
+    controller(idv_step_controller_class) do
       before_action :confirm_not_rate_limited_after_idv_resolution
     end
 
     before(:each) do
       sign_in(user)
       allow(subject).to receive(:current_user).and_return(user)
       routes.draw do
-        get 'show' => 'idv/step#show'
-        put 'update' => 'idv/step#update'
+        get 'show' => 'anonymous#show'
+        put 'update' => 'anonymous#update'
       end
     end