Add support for client-side OIDC redirect by UUID #9790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmargolis
approved these changes
Dec 18, 2023
Comment on lines
194
to
198
| server_side_uuid = IdentityConfig.store.openid_connect_redirect_server_side_uuids.include?(user_uuid) | ||
| client_side_uuid = IdentityConfig.store.openid_connect_redirect_client_side_uuids.include?(user_uuid) | ||
| client_side_js_uuid = IdentityConfig.store.openid_connect_redirect_client_side_js_uuids.include?(user_uuid) | ||
|
|
||
| default = IdentityConfig.store.openid_connect_redirect |
There was a problem hiding this comment.
it's potentially more error-prone in some ways, but if we had one config that was a hash/dictionary, we could just do one lookup and simplify a lot of this code?
config = {
"uuid-a" => "server_side",
"uuid-b" => "client_side",
# etc....
}.transform_values(&:to_sym)
case config.fetch(current_user.uuid, IdentityConfig.store.openid_connect_redirect)
There was a problem hiding this comment.
I like that better
There was a problem hiding this comment.
I opted to switch the values to strings though
mitchellhenke
force-pushed
the
mitchellhenke/more-oidc-client-side-config
branch
from
ab83790
to
c460a5f
Compare
changelog: Internal, OpenID Connect, Add support for client-side OIDC redirect Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
mitchellhenke
force-pushed
the
mitchellhenke/more-oidc-client-side-config
branch
from
c460a5f
to
2d54c18
Compare
zachmargolis
approved these changes
Dec 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃洜 Summary of changes
This adds another layer of configuration to help us debug and test changes around client-side redirect