-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy RC 14 to Prod #196
Merged
Merged
Deploy RC 14 to Prod #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why**: Resolve issue where `bundle install` fails with error. See: - macournoyer/thin#370 - https://stackoverflow.com/questions/63278694/thin-and-puma-fail-with-similar-issues-error-failed-to-build-gem-native-exten - https://stackoverflow.com/questions/63851404/an-error-occurred-while-installing-thin-1-7-2
Bump thin gem from 1.7.2. to 1.8.0
- Ex: /api/health/certs?deadline=7d **Why**: This allows us to query the endpoint with fixed strings for separate durations, so we could warn at a 30d expiration but have a seprate check that errors at a 7d expiration * Disable CodeClimate method-complexity (cognitive complexity) **Why**: To match IDP configs
- It expires Jan 2021. We already have the other DHS CA4 cert that does not expire until 2025, so no need to replace
- Also update certs:remove_invalid task to be able to delete future expiring certs
Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov>
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
…icy-oids Map piv/cac to the Federal Bridge CA if using valid policy OIDs (LG-3604)
- Stop at trusted roots - Add helper method to detect missing certs - Add helper to generate PEM filename
zachmargolis
approved these changes
Jan 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mitchellhenke
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.