Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LG-3930 Alert on expired cert when walking chain #185

Merged
merged 6 commits into from
Dec 21, 2020
Merged

LG-3930 Alert on expired cert when walking chain #185

merged 6 commits into from
Dec 21, 2020

Conversation

stevegsa
Copy link
Contributor

No description provided.

@stevegsa stevegsa marked this pull request as ready for review December 19, 2020 05:22
zachmargolis
zachmargolis approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some style suggestions

app/services/certificate_store.rb Outdated Show resolved Hide resolved
app/services/certificate_store.rb Outdated Show resolved Hide resolved
@stevegsa stevegsa merged commit 00c070b into master Dec 21, 2020
@stevegsa stevegsa deleted the stevegsa-alert-on-expired-cert-when-walking-chain branch December 21, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmargolis zachmargolis zachmargolis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevegsa @zachmargolis