Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not retry failures for OCSP (LG-4465) #223

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

mitchellhenke
Copy link
Contributor

We should fall back to the certificate revocation list instead of hammering struggling web services

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachmargolis
Copy link
Contributor

LMK if you want me to admin override for code coverage

@mitchellhenke
Copy link
Contributor Author

@zachmargolis yes please, I don't know how this could be a reduction in code coverage 🤷🏼‍♂️

@zachmargolis zachmargolis merged commit 1990435 into main Apr 7, 2021
@zachmargolis zachmargolis deleted the mitchellhenke/no-ocsp-retries-lg-4465 branch April 7, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants