This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Don't use deprecated mixin. #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bourbon is deprecating the `box-sizing` mixin because the CSS property is now well-supported across browsers. Using the mixin throws a warning with the current version of Bourbon and will error after the next major release. If we want to support very old browser versions, it's safest to add `-moz-box-sizing` etc. manually, but this probably isn't necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bourbon is deprecating the
box-sizingmixin because the CSS propertyis now well-supported across browsers. Using the mixin throws a warning
with the current version of Bourbon and will error after the next major
release. If we want to support very old browser versions, it's safest to
add
-moz-box-sizingetc. manually, but this probably isn't necessary.See https://github.com/thoughtbot/bourbon/blob/86d2147511265db9cdb35b497e195b8c4649ee98/app/assets/stylesheets/_bourbon-deprecated-upcoming.scss#L407-L411 for details.