Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

updated glossary icons #277

Merged
merged 1 commit into from
Jun 17, 2015
Merged

updated glossary icons #277

merged 1 commit into from
Jun 17, 2015

Conversation

noahmanger
Copy link
Contributor

This uses Jen's idea of a book icon in the header with little "i" (info) icons inline. I think the combo works well and is more clear than the question mark. That said, we won't know until we can get it in front of people, but was an easy change to make.

screen shot 2015-06-16 at 12 06 09 pm

This partially addresses https://github.com/18F/openFEC/issues/910 in so much as it attempts to make the glossary more discoverable. I still think a label could be a good addition, but might not be necessary.

@jmcarp
Copy link
Contributor

jmcarp commented Jun 16, 2015

This looks good to me. @noahmanger, do you want to get more feedback on this, or is it ready to merge?

@noahmanger
Copy link
Contributor Author

Anyone have objections? My $.02 is we should try it out.

@rdpiazza
Copy link

Really like the way the glossary icon looks, but I'd like to wait until the next iteration, since there could be things we'd overlook. For example, if we change the image on the top of the bar, we'll also need to change the text and image for "Need Help Understanding the Terms?" on the home page. Want to limit changes this close to go time.

@arowla
Copy link
Contributor

arowla commented Jun 17, 2015

I think this is a big improvement, but agree that waiting is probably best.

@noahmanger
Copy link
Contributor Author

+1 . Sounds good.

On Wed, Jun 17, 2015 at 7:28 AM, Alison Rowland notifications@github.com
wrote:

I think this is a big improvement, but agree that waiting is probably best.


Reply to this email directly or view it on GitHub
#277 (comment).

Noah Manger
18F http://18f.gsa.gov | Work: 415-696-6146

@jmcarp jmcarp merged commit fe6f097 into develop Jun 17, 2015
@noahmanger noahmanger deleted the feature/new-glossary-icons branch August 3, 2015 22:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants