This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
API Performance Refactor, Candidate Search Edition #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Show lesser of total count and number per page in the "viewing" range, e.g. "Viewing 1-3", where 3 is the total result set, instead of "Viewing 1-20", where there are only 3 results, but 20 is the default number shown per page.
- No longer need to handle a complex mapping on the front end
- Mistakenly removed it while dependencies still remained - Tests pass now
LindsayYoung
added a commit
that referenced
this pull request
Feb 11, 2015
API Performance Refactor, Candidate Search Edition
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes bring the front end in line with the back end's refactor of the candidate search (
/candidate) API endpoint. Merging this should be coordinated with the merge of 18F/openFEC#360.