This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/responsive-updates
…/responsive-updates
Only applies to the first time the page is loaded. This prevents the jumbled table headers from showing up on mobile before the table is loaded, and i think makes for a nice effect in general. In fed-style I set the opacity to fade in. What do you think @jmcarp
- And only showing ‘.hide-panel-tablet’ if above a phone size
…/responsive-updates
…/responsive-updates Conflicts: templates/committees-single.html
…/responsive-updates Conflicts: static/js/pages/elections.js
I'm going to merge now, but this could use a post-hoc code review from @msecret when time permits. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up mobile display of a bunch of pages and components:
More to come soon, but figured worth merging in smaller portions.
Styles are here: 18F/fec-style#86