This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Add endpoint for submitting issues to GitHub. #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| FeedbackWidget.prototype.submit = function(e) { | ||
| e.preventDefault(); | ||
| var promise = $.ajax({ |
There was a problem hiding this comment.
'promise' is defined but never used.
| @@ -87,6 +89,9 @@ $(document).ready(function() { | |||
| BASE_PATH | |||
| ); | |||
|
|
|||
| // Initialize feedback | |||
| new feedback.Feedback(helpers.buildAppUrl(['issue'])); | |||
There was a problem hiding this comment.
Do not use 'new' for side effects.
LindsayYoung
added a commit
that referenced
this pull request
Oct 13, 2015
Add endpoint for submitting issues to GitHub.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch needs some work from @noahmanger and @emileighoutlaw on style and content, respectively. We should also decide what happens to the reporting form on successful submission and on failure.