This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Skip links on null employer and occupation. #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we don't currently expose filters to restrict transctions by null employer or occupation, we don't have a good way to build links to itemized browse views for aggregates with null values. This patch omits links for these aggregate rows. h/t @noahmanger
|
Just to verify: Null employer and occupations get displayed as |
|
Null values will continue to be reported as "NOT REPORTED", and they won't have links at all, since there isn't a link we can build that would fetch transactions with null employers or occupations. This is based on Slack discussion yesterday, but happy to revise if there's a better approach. |
|
Oh, gotcha. I didn't realize "NOT REPORTED" was different than "N/A". |
noahmanger
pushed a commit
that referenced
this pull request
Oct 23, 2015
Skip links on null employer and occupation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't currently expose filters to restrict transctions by null
employer or occupation, we don't have a good way to build links to
itemized browse views for aggregates with null values. This patch omits
links for these aggregate rows.
To verify: browse to a committee detail page, receipts tab, employer or occupation aggregates; there should be the usual links to aggregates for non-null employers and occupations, but no links for null values.
h/t @noahmanger