This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Allow cross-origin requests to feedback endpoint. #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Necessary for feedback submission via the CMS application. Going forward, we may want to restrict the origin to beta.fec.gov, but this is fine for now. This becomes moot if the feedback widget is exported to a separate application.
|
Is there a way to test this? |
|
Yep--submitting feedback issues from the CMS shouldn't work without this patch. |
LindsayYoung
added a commit
that referenced
this pull request
Oct 26, 2015
Allow cross-origin requests to feedback endpoint.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary for feedback submission via the CMS application. Going
forward, we may want to restrict the origin to beta.fec.gov, but this is
fine for now. This becomes moot if the feedback widget is exported to a
separate application.
Required for https://github.com/18F/fec-cms/pull/98.
cc @LindsayYoung @noahmanger