Include DAP code for public sites #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartsick
approved these changes
Jan 26, 2022
|
|
||
| <% if Rails.env.production? %> | ||
| <!-- We participate in the US government's analytics program. See the data at analytics.usa.gov. --> | ||
| <%= javascript_include_tag "https://dap.digitalgov.gov/Universal-Federated-Analytics-Min.js?agency=GSA", async: true, id:"_fed_an_ua_tag" %> |
There was a problem hiding this comment.
[suggestion] If we expect this might be used for partner agencies (do we?) I wonder if we should at least flag in the README or a post-install message that GSA is specified as the DAP agency.
Also think it would be helpful to add a small note in the README about DAP inclusion regardless!
There was a problem hiding this comment.
Also think it would be helpful to add a small note in the README about DAP inclusion regardless!
good call, I'll add that before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.