This repository has been archived by the owner on Aug 15, 2024. It is now read-only.
Fix deployments #69
Merged
Fix deployments #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes the redundant `config_en.toml` file and adds the `lang="*"` property that was missing from the `config.toml`. When this property is missing from any config files, it causes `viper` the library that `hugo` uses to process config files to throw an unlabeled / unhelpful exception.
| - cf login -a https://api.cloud.gov -u $CF_GSA_VOTE_USER -p $CF_GSA_VOTE_PASS -o gsa-ffd -s vote-production | ||
| - cf push | ||
| staging: | ||
| branch: [staging] | ||
| commands: | ||
| - echo "CURRENTLY ONLY BUILDING SINGLE LANGUAGE SITE" | ||
| - SITE_BASEURL="$CF_GSA_VOTE_STAGING_URL" gulp build:website | ||
| - npm run build:staging |
There was a problem hiding this comment.
Have both CircleCI deployments leverage the new npm run scripts.
|
@yozlet Updated with the changes I mentioned above 👍 |
| "en": { | ||
| "staging": "https://vote-gov-staging.apps.cloud.gov/", | ||
| "production": "https://vote-gov.apps.cloud.gov/" | ||
| "votgov": { |
There was a problem hiding this comment.
I think you have a typo here - should be votegov (which you've used in the vars below), not votgov
There was a problem hiding this comment.
This is fixed @yozlet Good 👀
|
Do you want to open |
|
Done, in #73. Meanwhile, let's get this out there. 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When #33 landed, it broke the deployments because of a
go paniccaused with Hugo. I opened a ticket here gohugoio/hugo#2174 to alert the maintainers ofhugoabout the problem. I will outline in the PR what I did to fix it.This patch series also includes some refactoring of the
npm runscripts along with leveraging thenpm configto establish some repeatable environmental variables. You can find out more about that here.