Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team section is wonky at mobile viewport size #73

Closed
quepol opened this issue May 29, 2014 · 4 comments
Closed

Team section is wonky at mobile viewport size #73

quepol opened this issue May 29, 2014 · 4 comments

Comments

@quepol
Copy link
Contributor

quepol commented May 29, 2014

Newest additions to team section have put some of the rows off kilter.

Need to fix and check at mobile/tablet sizes.

Possibly rework code to get rid of rows and make it one big div that wraps?

@aaronsnow
Copy link
Contributor

Detail and possible fix: The bug occurs (at least) on iPhone, when there are two people per row, one with a name that wraps to a second line (e.g., Jamie in the screenshot below), the other with a name that only takes up one line (Leah). Whoever's next (Nick) gets bumped to the right, leaving a blank space beneath the two-line name; and then the next person (Gray) gets their own line beneath that.

This CSS seems to fix the problem on iPhone; I don't have an Android to test against:

.bio.col-xs-6 {
  min-height: 143px;
}

Screenshot of the problem:
image

@quepol
Copy link
Contributor Author

quepol commented Jun 11, 2014

@aaronsnow can you repeat your test and confirm if this is still happening?

@ultrasaurus
Copy link
Contributor

this still looks wonky on my iPhone 5 (iOS 7.1.1)

@quepol
Copy link
Contributor Author

quepol commented Jun 11, 2014

fixed in PR #84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants