Skip to content
This repository has been archived by the owner on Dec 8, 2017. It is now read-only.

newsclips - where to fit in #38

Closed
gbinal opened this issue Jan 8, 2015 · 17 comments
Closed

newsclips - where to fit in #38

gbinal opened this issue Jan 8, 2015 · 17 comments

Comments

@gbinal
Copy link
Member

gbinal commented Jan 8, 2015

I've been keeping a list of 18F news clips in /team-ops, but can move them here. Any preference as to where I put them? I can forklift it as a page onto 18f.gsa.gov/hub easily enough but @mbland, do you have something else in mind?

@OriHoffer, @gboone - any thoughts?

[This is in support of https://github.com/18F/hub-pages-private/issues/3]

@meiqimichelle
Copy link
Contributor

@gbinal Are the newsclips already in yml (I don't know how github wikis work)? If no, I suggest that as a first step. I could see us pulling this into several parts of the 18f site once its revamped (never fear....still in process and moving). @gboone @mbland thoughts?

@gbinal
Copy link
Member Author

gbinal commented Jan 8, 2015

No, just hyperlinked in github markdown. I'm happy to convert them but would just need to know where to put the material.

@meiqimichelle
Copy link
Contributor

Got it. Well, before you spend the time doing it, I'll let @gboone and @mbland weigh in. I would imagine that the file would go....hmmm....maybe in the data-private repo if that is becoming our 18F data repo in general, but I might not be privy to the latest thinking there.

@gboone
Copy link
Contributor

gboone commented Jan 8, 2015

Good idea bringing this into the Hub or 18f-site. If it's just links and dates it could be yaml data. If we're going to summarize them at all it might be worth creating a collection for news clips.

@gbinal
Copy link
Member Author

gbinal commented Jan 8, 2015

Let's go with yaml for now. I've only had the bandwidth to keep track of article links and titles and am not in a position to expand that.

FWIW, I'm not advocating adding this to the main 18f.gsa.gov. Personally, I think that'd be a bit garish. It's more a team resource that doesn't need to be private.

@meiqimichelle
Copy link
Contributor

We'll see. It might be interesting to have just the latest news clip show
up somewhere. But yes, understood ;)

On Thu, Jan 8, 2015 at 10:20 AM, Gray Brooks notifications@github.com
wrote:

Let's go with yaml for now. I've only had the bandwidth to keep track of
article links and titles and am not in a position to expand that.

FWIW, I'm not advocating adding this to the main 18f.gsa.gov. Personally,
I think that'd be a bit garish. It's more a team resource that doesn't need
to be private.


Reply to this email directly or view it on GitHub
#38 (comment).

Michelle Hertzfeld
michelle.hertzfeld@gsa.gov
520-208-3752
202-317-0155
@18F

@afeld
Copy link
Contributor

afeld commented Jan 8, 2015

It's more a team resource that doesn't need to be private.

Sounds like a good use case for a sub-page of the Hub, then 👍

https://github.com/18F/hub/tree/master/pages#publicly-visible-pages

@afeld
Copy link
Contributor

afeld commented Jan 8, 2015

...and can be fed by a data file in https://github.com/18F/hub/tree/master/_data, if you like.

@gbinal
Copy link
Member Author

gbinal commented Jan 9, 2015

I'm happy to put them in as yml in /_data and we can figure out what to do with them.

Just to check, does this look okay to start? (it's the data I have, I'm just asking about format)

- article: Full Text Of Title
  url: http://www.publication.com/name_of_article
- article: Full Text Of Title, 2
  url: http://www.publication.com/name_of_article_2

@afeld
Copy link
Contributor

afeld commented Jan 9, 2015

👍

@gbinal
Copy link
Member Author

gbinal commented Jan 9, 2015

#44

@gbinal
Copy link
Member Author

gbinal commented Jan 9, 2015

Just to confirm, I don't plan to do individual additions to the clips.yml through pull requests but rather as direct commits. Holler if that's any concern, @afeld, @mbland

@afeld
Copy link
Contributor

afeld commented Jan 9, 2015

Nah that's fine. But if it breaks the build, I will find you :rage1:

😉

@gbinal
Copy link
Member Author

gbinal commented Jan 9, 2015

:)

@mbland
Copy link
Contributor

mbland commented Jan 9, 2015

@gbinal For stuff like this that's hard to screw up, that's perfectly fine. Though you may want to do something like the following for a sanity check:

$ ruby -e "require 'yaml'; puts YAML.load_file '_data/public/clips.yml'"

Whoops, I just noticed two things: One, that _data/public really isn't the best place for clips.yml. No matter; we can move it when we get ready to prepare the page. (And, I can better document that no data should be directly added to _data/public; it's an honest mistake and my fault for not having it better documented by now.)

Two:

/usr/local/var/rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/psych-2.0.9/lib/psych.rb:370:in `parse': (_data/public/clips.yml): mapping values are not allowed in this context at line 2 column 26 (Psych::SyntaxError)

The first article: entry contains a colon. I think it needs to be wrapped in quotes. Same for lines 41, 44, 62, 80, 86, 128, 146, 158, 185, and 266. PR to fix: #46

@gbinal
Copy link
Member Author

gbinal commented Jan 9, 2015

Have tried a first pass at making an html page at #47

@afeld, game to take a look?

@gbinal
Copy link
Member Author

gbinal commented Jan 14, 2015

Like @afeld says, #47 addresses

@gbinal gbinal closed this as completed Jan 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants