Skip to content
This repository has been archived by the owner on Jul 30, 2019. It is now read-only.

Expand the README #5

Closed
khandelwal opened this issue Oct 8, 2015 · 7 comments
Closed

Expand the README #5

khandelwal opened this issue Oct 8, 2015 · 7 comments

Comments

@khandelwal
Copy link

Flush out the README so that it's clear what's going on here.

What does this software do?
Why is it needed?
What's the micro-purchase experiment?

If one wants to run a local copy of this, how does one do it?

@blacktm blacktm closed this as completed Oct 19, 2015
@khandelwal khandelwal reopened this Oct 19, 2015
@khandelwal
Copy link
Author

The new README doesn't explain what this repository is for, or what this software does. What are it's features? Why is new software required for a micro-purchase experiment?

@blacktm
Copy link
Contributor

blacktm commented Oct 19, 2015

How about this:

This app will be used to manage bids for 18F's micro-purchase threshold experiment. Vendors will be able to view open issues and bid on them, given they have GitHub accounts and are registered on SAM.gov.

As we add features, we'll document them. Also, not sure what's expected for "why software is required" – because we don't want to do this manually? Seems weird to explicitly say that.

@khandelwal
Copy link
Author

That sentence works. Let's add it in (but please pull request).

@blacktm
Copy link
Contributor

blacktm commented Oct 19, 2015

So just to be clear, our policy is to never ever commit to master, no matter how trivial (I'm seriously asking)?

@blacktm blacktm mentioned this issue Oct 19, 2015
@khandelwal
Copy link
Author

Yes!

@blacktm
Copy link
Contributor

blacktm commented Oct 19, 2015

LET IT BE SO. :godmode:

@blacktm
Copy link
Contributor

blacktm commented Oct 19, 2015

Ok, so I've opened a PR to update the README at #26. What's the protocol for it merging into master? Do I have to wait for another member of 18F Consulting to review before merging, or can I self-review my own PR? If I'm confident in the PR and it passes all tests, can I merge the PR without review? With review, I'm I able to merge the PR myself, or should the the PR author never be allowed to merge their own PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants