Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require to implement method map_name_to_column #5

Open
AmShaegar13 opened this issue Feb 16, 2017 · 1 comment
Open

Do not require to implement method map_name_to_column #5

AmShaegar13 opened this issue Feb 16, 2017 · 1 comment
Assignees
Milestone

Comments

@AmShaegar13
Copy link
Contributor

Requiring the model to implement a specific method feels wrong and not rails-like. Better configure aliases through a method call in the model like associations are. E.g.

class User < ActiveRecord::Base
  api_aliases team: 'team.identifier', birthday: :dob
end

This is a breaking change as it requires the models to be changed.

@AmShaegar13 AmShaegar13 added this to the v2.0 milestone Feb 16, 2017
@AmShaegar13 AmShaegar13 self-assigned this Feb 16, 2017
@AmShaegar13
Copy link
Contributor Author

Adjust README and add CHANGELOG entry.

@AmShaegar13 AmShaegar13 reopened this Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant