Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create update_editing-units.md #1

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Conversation

1jc
Copy link
Owner

@1jc 1jc commented Sep 6, 2023

issue OpenEnergyDashboard#906

Description

(Please include a summary of the change and which issue is touched on. Please also include relevant motivation and context.)

Describe the bug
If you change what a unit represents then bad things can happen. A conversion might now exist between different types of units. During creation this is not allowed. This is esp. dangerous if this is the meter graphing unit.

Expected behavior
OED should stop a user from making this type of edit and be told to fix up the dependencies. Similar types of checks happen in group edits.

Fixes #[906]

Type of change

(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])

  • Note merging this changes the database configuration.
  • [x ] This change requires a documentation update

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

  • [x ] I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request

Limitations

none

@1jc 1jc added the documentation Improvements or additions to documentation label Sep 6, 2023
@1jc 1jc self-assigned this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
1 participant