Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests could be more fine-grained and automatized #4

Closed
kjappelbaum opened this issue Nov 7, 2019 · 4 comments
Closed

Tests could be more fine-grained and automatized #4

kjappelbaum opened this issue Nov 7, 2019 · 4 comments

Comments

@kjappelbaum
Copy link

Hi, again for the JOSS review.

I saw that you have a test case for the code, which is great! If you want to improve on that you can write unit tests that test each (relevant) function (this makes it easier for new contributors to see where exactly they break your code) and run those tests automatically, e.g. with pytest on different platforms using e.g. travis or azure pipelines.

@mgdotdev
Copy link
Owner

mgdotdev commented Nov 8, 2019

I'll look into travis/pytest integration in the future, but for now I added a bit to the libRL_test so to provide full test coverage of the library.

@kjappelbaum
Copy link
Author

Yes, automated testing with coverage report with a badge on the README would be useful. And testing the addition of test would be could (might be nicer to keep them separate to track down what fails. But the project is small so it doesn't matter than much).

But I still do not know if just checking the best test case.

@mgdotdev
Copy link
Owner

Okay, was finally able to get all that working haha.

Added travis-CI integration and documentation through sphinx.

@kjappelbaum
Copy link
Author

Great, closing this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants