Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less default styles / theming support #17

Closed
onli opened this issue Aug 18, 2018 · 2 comments
Closed

Less default styles / theming support #17

onli opened this issue Aug 18, 2018 · 2 comments
Labels
question Further information is requested

Comments

@onli
Copy link

onli commented Aug 18, 2018

Hi. Thanks for this work.

The css has some styles that will clash with many site designs, like font-family: Arial, 'Helvetica Neue', Helvetica, sans-serif; It would be great if the css could be splitted: One providing the core css absolutely necessary for placement etc, and one second css file with the css specific to the design.

Like with http://github.hubspot.com/vex/ that could result in support for included themes, but more important is that it owuld make it easier to make jplist for the the site design.

@1rosehip
Copy link
Owner

Hi,
Thank you for the feedback.
This version of jPList almost doesn't have CSS styles and in most examples uses Bootstrap framework for demo pages. Developer may use any styles / frameworks that needed and any HTML structure. The only exception is custom dropdown control and range slider as it's not possible to implement them without CSS, but even in these cases the styles are minimal and can be changed in any way.

@1rosehip 1rosehip added the question Further information is requested label Aug 22, 2018
@onli
Copy link
Author

onli commented Aug 22, 2018

Hi, thanks for your answer. The examples tricked me by reusing the bootstrap styles, but that is exactly what is wanted. Very nice.

https://github.com/1rosehip/jplist-es6/blob/master/dist/1.1.2/jplist.styles.css does indeed not many styles. The font-family thing I mentioned, and some color assignments. I believe you that those are really necessary for making the dropdown works.

Looks nice so far!

@onli onli closed this as completed Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants